new Toggle component #92
Conversation
| width: 40, | ||
| }; | ||
|
|
||
| export const thumbStyle = { |
There was a problem hiding this comment.
Can we add a border of 1px and make it COLORS.border to the thumb
There was a problem hiding this comment.
And make the background color of the thumb, white.
| width: 40, | ||
| }; | ||
|
|
||
| export const thumbStyle = { |
There was a problem hiding this comment.
Also looks like the thumb needs to be nudged over 1px when it's toggled on and toggled off.
There was a problem hiding this comment.
I moved it closer to edge 1 pixel when active, moving 1 more pixel closer to each edge started to feel odd for me, take a look this is one more pixel to each side
There was a problem hiding this comment.
Okay let's go with whatever is marked Current. I don't know what I was seeing
| margin-right: ${SPACING.xsmall}; | ||
| `; | ||
|
|
||
| export const trackStyle = { |
There was a problem hiding this comment.
Can we make the track background color purple15? That's on me. It wasn't included in the design mocks but I think it will be better. It also matches our disabled button styling.
redesigned according to https://www.figma.com/file/RZIO3wuO5Uk7sPZoXstAuXIA/Radiance.UI-(Master)?node-id=1%3A9
I also added the click handler to the label